getredash/redash

Visualization map (markers) doesn't reset with data

Open

#3313 opened on Jan 20, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (24,845 stars) (4,236 forks)batch import
BugFrontendhelp wanted

Description

Issue Summary

When I use a query filter to narrow down some geo data, the map view doesn't reset to line up with the map markers currently being displayed. The viewbox on the map stays wrapped around the first set of data (even after it disappears). So I have to zoom and drag the map manually to see the data.

Steps to Reproduce

  1. Load this data set from gh and then manipulate it with the Query Results data source.
  2. Use a query filter to limit the data by state name
  3. Make a map (markers) visualization
  4. Change the query filter
  5. Observe that the the map visualization doesn't update with a different data set.

I would expect the map to update its viewport to wrap around the most recently rendered coordiantes.

Technical details:

  • Redash Version: 431d6fa
  • Browser/OS: Chrome 71
  • How did you install Redash: Saas Product

Contributor guide

Tech stack
pythonjavascriptreact
Domain
frontenddata
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptReactMap libraryRedash development setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review the map visualization component in the Redash frontend codebase (likely under `client/app/components/visualizations/map/`). Understand how the viewport is set initially when data loads. Identify the logic that updates the viewport when data changes and ensure it resets the viewbox to fit new markers. Check if there is a method to fit bounds on data update. No linked PRs or comments exist.