getredash/redash

Google Spreadsheets: when the spreadsheet not found show the service account email address

Open

#2,940 opened on Oct 14, 2018

View on GitHub
 (12 comments) (1 reaction) (0 assignees)Python (4,236 forks)batch import
BackendUXhacktoberfest

Repository metrics

Stars
 (24,845 stars)
PR merge metrics
 (Avg merge 9d 5h) (3 merged PRs in 30d)

Description

When trying to query a Google Spreadsheet and it wasn't found, as part of the message to the user show the service account email address.

Reasoning: many times the user tries to share it with their own email address or just not sure what address to share it with.

The Google Spreadsheet query runner implemented in this module: https://github.com/getredash/redash/blob/master/redash/query_runner/google_spreadsheets.py

Will need to alter this error message: https://github.com/getredash/redash/blob/e87efc8bc30cefa0176fea7f12169cf202452727/redash/query_runner/google_spreadsheets.py#L215

The service account email address is in the JSON key file.

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.