getredash/redash

Load unformatted numbers from Google Spreadsheets

Open

#2923 opened on Oct 10, 2018

View on GitHub
 (6 comments) (3 reactions) (0 assignees)Python (24,845 stars) (4,236 forks)batch import
Backendenhancementhelp wanted

Description

By default gspread loads formatted values from Google Spreadsheets, but it makes more sense to load unformatted values (123.0 instead of $123.0).

We use the get_all_values method. Unlike other getters this one doesn't take a value_render_option, but we can:

  1. Reimplement its behavior by using the lower level API it calls.
  2. Submit a pull request upstream to take this option for this method too.

Contributor guide

Tech stack
python
Domain
backenddata
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythongspread libraryGoogle Sheets API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the current implementation of Worksheet.get all values in the redash codebase and the gspread library. The issue suggests two approaches: reimplement get all values to use the lower level API that supports value render option, or submit a pull request upstream to gspread to add support for value render option in get all values. Examine the gspread source to understand if the second approach is feasible and check if there are any existing PRs or discussions upstream. Based on findings, decide which approach is more appropriate and propose changes.