getredash/redash

Add `hd` parameter for optimized Google Apps login

Open

#1924 opened on Aug 9, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (24,845 stars) (4,236 forks)batch import
Backendenhancementhelp wanted

Description

https://github.com/getredash/redash/blob/53268989c5fe5c619b399b488094c501cb286af4/redash/authentication/google_oauth.py#L91

Would it be possible to add the hd parameter to this authorization URL in the event that there's a single allowed Google Apps domain? It optimizes the sign in experience by limiting the suggested accounts to those for the passed Google domain.

If you're signed in to a single account on the domain and already authorized Redash: instant redirect to login.

If you're signed in on the domain and haven't authorized Redash: present only accounts from the authorized Google domain.

If you're not signed in: present the login dialog with your domain pre-filled.

If you're interested in merging something like this but can't prioritize this as a feature I can put together a PR with the changes required.

Contributor guide

Tech stack
python
Domain
authentication
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
OAuth 2.0 knowledgePython basicsRedash codebase familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue requests adding the 'hd' parameter to the Google OAuth authorization URL in redash/authentication/google oauth.py at line 91. The implementation should check for a configured Google Apps domain and append the hd query parameter. Review existing OAuth flow and configuration settings to add a new setting for the allowed domain. No linked PRs or comments indicate ongoing work.