getredash/redash

Add `hd` parameter for optimized Google Apps login

Open

#1,924 opened on Aug 9, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (4,236 forks)batch import
Backendenhancementhelp wanted

Repository metrics

Stars
 (24,845 stars)
PR merge metrics
 (Avg merge 9d 5h) (3 merged PRs in 30d)

Description

https://github.com/getredash/redash/blob/53268989c5fe5c619b399b488094c501cb286af4/redash/authentication/google_oauth.py#L91

Would it be possible to add the hd parameter to this authorization URL in the event that there's a single allowed Google Apps domain? It optimizes the sign in experience by limiting the suggested accounts to those for the passed Google domain.

If you're signed in to a single account on the domain and already authorized Redash: instant redirect to login.

If you're signed in on the domain and haven't authorized Redash: present only accounts from the authorized Google domain.

If you're not signed in: present the login dialog with your domain pre-filled.

If you're interested in merging something like this but can't prioritize this as a feature I can put together a PR with the changes required.

Contributor guide

Research direction
Implement the 'hd' parameter in the Google OAuth authorization URL to restrict login to a specific Google Apps domain.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70