getredash/redash

Allow name and email for user added by Remote User Auth to be different

Open

#1,648 opened on Mar 2, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Python (4,236 forks)batch import
Backendenhancementhelp wanted

Repository metrics

Stars
 (24,845 stars)
PR merge metrics
 (Avg merge 9d 5h) (3 merged PRs in 30d)

Description

Issue Summary

I'm trying to use Active Directory LDAP through remote_user_auth module. Currently there is no way to set different redash user name from mail address. So now my redash user accounts have mail address for both name and mail. Also, if user logs in with just the username or username@domain, the mail address is not correct and the alarm mail won't work.

Technical details:

To solve this, I guess we have to add another environment variable besides REMOTE_USER_HEADER.

Does it make sense to you to add variable like REMOTE_MAIL_HEADER, and use it like

name = REMOTE_USER_HEADER
email = REMOTE_MAIL_HEADER || REMOTE_USER_HEADER
create_and_login_user(current_org, name, email)

instead of

email = REMOTE_USER_HEADER
create_and_login_user(current_org, email, email)
  • Redash Version:Current Head
  • Browser/OS:Chrome
  • How did you install Redash:Docker

Contributor guide

Research direction
Examine the remote user auth module in Redash, explore how REMOTE USER HEADER is used, and implement a new environment variable REMOTE MAIL HEADER that allows separate email header while keeping name from REMOTE USER HEADER for backward compatibility.
Tech stack
python
Domain
backendauthentication
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75