getify/literalizer

fix how template literal is processed

Open

#26 opened on Jan 7, 2015

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (2 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (18 stars)
PR merge metrics
 (PR metrics pending)

Description

There are quite a few problems with the existing implementation regarding template literals. Off the top of my head:

  1. the way it looks for the ending after starting a template literal is wrong. Instead of just looking for the next, it should count them in a stack, much like matching { } or ( ) pairs would be done.
  2. Template literals can have other template literals inside their expressions.
  3. Each ${ inside the literal should break out and just create elements of text (code), but must track { } pairs so it can identify the ending }, and go back into template literal mode, resuming its search for either ${ or ```.
  4. The tagged identifier before a template literal, if present, should be included as part of the first template literal element in the stream. heuristic: preceding whitespace then identifier.

Contributor guide

Research direction
Understand the current implementation of template literal handling in the lexer. Trace the flow for encountering a backtick. Implement a stack based approach to match backticks and handle nested template literals and expressions. Ensure proper handling of ${...} with nested braces.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptBasic parsing concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60