getify/grips

grips-css: function to normalize selectors

Open

#15 opened on Mar 11, 2014

View on GitHub
 (0 comments) (0 reactions) (1 assignee)JavaScript (22 forks)github user discovery
help wanted

Repository metrics

Stars
 (288 stars)
PR merge metrics
 (PR metrics pending)

Description

Whenever selectors are processed by the codegen, and they are base64 encoded for the grips partial id's, these selectors need to be normalized. Whenever render(..) is called with a selector, that selector should be normalized, so it can match when base64 encoded the proper grips partial.

Examples of necessary normalizations:

foo     bar

-> foo bar

foo     >       bar

-> foo > bar

foo    /* something */    bar

-> foo bar

Contributor guide

Research direction
Look at how selectors are handled in the `render` function and where base64 encoding happens. Add a normalization function that collapses multiple whitespaces and removes comments, then apply it before encoding or matching.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80