getify/cloud-sweeper

fix: orientation/dimensions sometimes borked on launch

Open

#30 opened on Feb 23, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (17 forks)github user discovery
help wanted

Repository metrics

Stars
 (96 stars)
PR merge metrics
 (PR metrics pending)

Description

noticed that when app is pinned to home screen (tested with android 5), upon launching sometimes the orientation lock seems to mess up the detected dimensions, so the welcome screen draws wrongly.

could be that orientation change doesn't fire resize? is there an orientation change event to also listen to perhaps?

Contributor guide

Research direction
Investigate if orientation change events (e.g., 'orientationchange' or 'resize') are not being fired on launch when pinned to home screen. Consider adding an event listener for orientation changes to recalculate dimensions.
Tech stack
javascript
Domain
frontendmobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
JavaScriptWeb development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60