getify/cloud-sweeper

refactor: use the constructor pattern on frequently made objects (perf)

Open

#25 opened on Feb 16, 2016

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (17 forks)github user discovery
help wanted

Repository metrics

Stars
 (96 stars)
PR merge metrics
 (PR metrics pending)

Description

I'm not a big fan of the constructor pattern, as most people who follow me know.

But it does seem to help when objects have a predictable shape and are created frequently. NOTE: this has nothing to do with using classes as a design pattern. It's a way to declare the shape of the object in a way that the engine can pre-optimize for.

ex:

// instead of:
var obj = { x: .., y: .., z: .. }

// do:
function makeObj() {
   this.x = ..
   this.y = ..
   this.z = ..
}
var obj = new makeObj();

Contributor guide

Research direction
Identify objects created frequently in the game loop (e.g., positions, states) and refactor them to use the constructor pattern (new MakeObj()) instead of plain object literals. Benchmark before and after to confirm performance gains.
Tech stack
javascript
Domain
game devfrontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65