getify/asynquence

improve `wrap(..)`

Open

#108 opened on May 23, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,739 stars) (156 forks)batch import
help wanted

Description

Take a trick from Node's promisify(..) utility... if asked to promisify a function that has a special symbol on it, the function at that symbol is returned, instead of creating a new one. Allows overriding the behavior of wrap not with the config params, but with meta data on the function being wrapped. Clever and useful.

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic JavaScriptunderstanding of symbols
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the current `wrap` function in asynquence's source code, likely in `asq.js` or similar. Implement a mechanism to check if a function passed to `wrap` has a specific symbol property; if so, return that function instead of creating a new wrapped version. The symbol should be defined and exported. Consider adding tests and documentation updates.