getgrav/grav

Uri should prefer port in HTTP_HOST and not take SERVER_PORT

Open

#1999 opened on Apr 27, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)PHP (15,491 stars) (1,409 forks)batch import
enhancementhelp wanted

Description

I run Grav in a docker container and use a different port internally. Uris get messed up for me because I map the internal docker port to a different port on the host.

Grav removes (correct) port from HTTP_HOST: https://github.com/getgrav/grav/blob/develop/system/src/Grav/Common/Uri.php#L1138

And takes the (wrong) port from SERVER_PORT. https://github.com/getgrav/grav/blob/develop/system/src/Grav/Common/Uri.php#L1144

Grav should take the port as the request was made, which is the port from HTTP_HOST.

Contributor guide

Tech stack
None
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PHPHTTP protocol basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is in getgrav/grav repository, specifically in Uri.php lines 1138 and 1144. The problem is that Grav prefers the port from SERVER PORT over the port from HTTP HOST when they differ, which is incorrect for containerized environments with port mapping. The fix should ensure that the port from HTTP HOST is used if present, falling back to SERVER PORT only when HTTP HOST lacks a port. To implement, modify the logic in Uri.php to check HTTP HOST first for a port, and only use SERVER PORT if no port is found in HTTP HOST. Review the existing code and consider adding a test for this behavior.