getgrav/grav

Uri should prefer port in HTTP_HOST and not take SERVER_PORT

Open

#1,999 opened on Apr 27, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)PHP (1,409 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (15,491 stars)
PR merge metrics
 (Avg merge 4d 13h) (8 merged PRs in 30d)

Description

I run Grav in a docker container and use a different port internally. Uris get messed up for me because I map the internal docker port to a different port on the host.

Grav removes (correct) port from HTTP_HOST: https://github.com/getgrav/grav/blob/develop/system/src/Grav/Common/Uri.php#L1138

And takes the (wrong) port from SERVER_PORT. https://github.com/getgrav/grav/blob/develop/system/src/Grav/Common/Uri.php#L1144

Grav should take the port as the request was made, which is the port from HTTP_HOST.

Contributor guide

Research direction
Examine the URI handling code in Grav's Uri.php, specifically lines around 1138 and 1144. Understand why port from HTTP HOST is stripped and SERVER PORT is used. Propose a change to prefer the port from HTTP HOST when present, falling back to SERVER PORT only if HTTP HOST lacks a port.
Tech stack
php
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70