[OpenCage] configure guessing order
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start by comparing the locality orders in conf/countries/worldwide.yaml with the code that uses the $localityKeys array. Make the guessing order configurable without losing the country-specific behavior, and verify that the example resolves Sankt Augustin rather than Rhein-Sieg-Kreis as the city.
Written by the indexing model from the issue text.
Description
It would be great, if the guessing order could be configured instead of being hard coded.
For example for this result in Germany: '53757, Sankt Augustin, Grantham Allee 20, Deutschland' the returned components are:
"components": {
"ISO_3166-1_alpha-2": "DE",
"ISO_3166-1_alpha-3": "DEU",
"_category": "commerce",
"_type": "shop",
"city": "Rhein-Sieg-Kreis",
"continent": "Europe",
"country": "Deutschland",
"country_code": "de",
"county": "Rhein-Sieg-Kreis",
"house_number": "20",
"political_union": "European Union",
"postcode": "53757",
"road": "Grantham-Allee",
"shop": "Druckpunkt",
"state": "Nordrhein-Westfalen",
"state_code": "NW",
"suburb": "Mülldorf",
"town": "Sankt Augustin"
}
Due to the current locality order 'Rhein-Sieg-Kreis' will be returned as city, but 'Sankt Augustin' would be correct. In comparison to the formatted field of the OpenCage-result "Druckpunkt, Grantham-Allee 20, 53757 Sankt Augustin, Deutschland" where the city is set properly.
https://github.com/OpenCageData/address-formatting/blob/master/conf/countries/worldwide.yaml
shows different orders depending for different countries.
In my opinion a simple solution could be to make the $localityKeys array public and static.
- Dominant language
- PHP
- Stars
- 4k
- Forks
- 525
- Avg merge
- 8m
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from geocoder-php/Geocoder
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
geocoder-php/Geocoder#1272 ·
-
question
Difficulty 4/5 3-5 days Newbie friendliness 25/100
geocoder-php/Geocoder#1267 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
geocoder-php/Geocoder#1266 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 38/100
geocoder-php/Geocoder#1244 · 2 comments · 2 reactions ·
-
provider
Difficulty 4/5 3-5 days Newbie friendliness 30/100
geocoder-php/Geocoder#1243 ·
All issues in geocoder-php/Geocoder
Similar issues
-
priority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
googleapis/librarian#7636 ·
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nextcloud/fulltextsearch#1011 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
coollabsio/coolify#11927 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100