_install doesn't handle download failure
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start in rgbenv at _install, especially lines 334-346, and trace the commands run when the downloaded tempfile is not a valid tarball. Verify the tar failure handling with a failed download or invalid archive; done means later extraction, moving, changing directories, and make steps are not attempted after the download failure.
Written by the indexing model from the issue text.
Description
The _install function will fail pretty messily in case of a number of errors, but particularly in case of the download failing.
https://github.com/gbdev/rgbenv/blob/251577417781a4e8b70da719cf1808e5ecbf6d89/rgbenv#L334-L346
if $tempfile is not a valid tarball, i.e. if the download fails:
tar -twill fail$dirnamewill be empty, ideallytar -xwill failmvwill fail, trying to move the versions directory into itselfcdwill failmakewill be invoked in the version directory, probably "no makefile found" error- a message will be printed saying that "You may still use this version, just with missing tools."
The most basic thing to add would be checking tar's exit status, which would catch a lot of potential problems.
- Dominant language
- Shell
- Stars
- 12
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from gbdev/rgbenv
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
-
Difficulty 3/5 1-2 days Newbie friendliness 42/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
docs(agents): strengthen the no-backslash-escaped-backticks rule with an issue-creation example Open
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
package-update
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
oSoWoSo/vOid_Community_repOsitory#148 · 1 comment ·
-
chore
Difficulty 1/5 Under an hour Newbie friendliness 91/100
alunduil/alunduil-chezmoi#792 ·
-
area: compat bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
zenhub-dev
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
OpenLiberty/ci.docker#747 ·