test/plan-count-file-permission.test.ts: "cropped" / "path-cropped" variants fail on macOS — fake 120-column terminal crops the path at every possible $TMPDIR

Open Beginner friendly
#2,911 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript
Domain
cli, testing-qa

Research direction

Start with test/plan-count-file-permission.test.ts and inspect the "cropped" and "path-cropped" variants that use a fake 120-column PTY. Reproduce the path-length assumptions on macOS, then adjust the terminal width or assertion as appropriate. Done means these variants pass with macOS temp-directory paths while preserving the intended cropping checks.

Written by the indexing model from the issue text.

Description

Version: seen on v1.87.0.0 (passed once at v1.87.4.0, may be flaky rather than fixed). Platform: macOS. CI (ubuntu) is green.

These variants render into a fake 120-column PTY and compare the on-screen path. The runner nests 29 characters under $TMPDIR; the assertion only holds when $TMPDIR is <= 40 characters. macOS's default per-user temp dir is ~49 characters (/var/folders/xx/.../T) and even the shortest possible override, /private/tmp/X, yields 43 after nesting, so no Mac can pass. Suggest widening the fake terminal for these variants or asserting on the basename.

Dominant language
TypeScript
Stars
134k
Forks
19.9k
Avg merge
20h 59m
Merged PRs (30d)
21

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from garrytan/gstack

All issues in garrytan/gstack

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.