garris/BackstopJS

approve button doesn't update reference image in UI

Open

#1194 opened on May 18, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (6,510 stars) (601 forks)batch import
help wanted

Description

I am seeing an issue where using approve button doesn't update reference image in the report UI -- however, it does successfully run the approve on the back end -- so this is just a UI issue.

This is most noticeable when you've run backstop for the first time as with the sanity test described here... https://github.com/garris/BackstopJS#sanity-test-does-backstop-work-in-my-environment

Here is what it looked like for me. I expected the reference image column to be updated with the test image... approve does not load approved image or clean up warning

Run this command to try it yourself...

mkdir backstopSanityTest; cd backstopSanityTest; npm install backstopjs; node ./node_modules/backstopjs/cli/ init; node ./node_modules/backstopjs/cli/ remote & node ./node_modules/backstopjs/cli/ test && fg

The above script will create a test directory, install backstop, start a remote process and run a test. Once the test completes it the terminal will bring the remote process to the foreground so you can kill it when you're done testing.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontendtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptBackstopJS basicsHTML/CSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the UI code that handles the approve button click event. The backend approve works, so the frontend likely fails to update the reference image state or re fetch the image. Look for the relevant component in the report UI, likely in the 'compare' or 'approve' module. There is one comment on the issue that may provide additional context.