Datasets counts are inflated

Open Beginner friendly
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
70/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
shell, sql
Domain
cli, data

Research direction

Start at kui.sh around line 155 and trace the gxadmin dataset-count entry point. Compare its current dataset query with the examples in the issue, then verify that deleted datasets are excluded from the reported count and validate the result against the provided SQL counts.

Written by the indexing model from the issue text.

Description

The gxadmin dataset-count command used in the script includes deleted datasets:

$ gxadmin query dataset-count 2007-01-01
 num_datasets
--------------
         6742

$ gxadmin query q "SELECT count(id) FROM dataset where create_time<'2007-01-01'"
 count
-------
  6742

$ gxadmin query q "SELECT count(id) FROM dataset where create_time<'2007-01-01' and deleted=false"
 count
-------
  1090

We likely don't want those counted?

Dominant language
Shell
Stars
3
Forks
1
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from galaxyproject/kui

All issues in galaxyproject/kui

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.