gajus/youtube-player

Event handlers cannot be overwritten - With react

Open

#62 opened on Jun 15, 2017

View on GitHub
 (3 comments) (4 reactions) (1 assignee)JavaScript (80 forks)github user discovery
enhancementhelp wantedquestion

Repository metrics

Stars
 (386 stars)
PR merge metrics
 (PR metrics pending)

Description

Hi,

I'm using your youtube-player with react and I pleased of how it work but I have a problem when I want to destroy and recreate a player.

If you don't know how react work there is the event componentDidMount and componentWillUnmount that are called when the component is created and destroyed.

At componentWillUnmount I create the player and bind one event. When componentWillUnmount is launch (changing page for example) I unbind the player event. But when I create again the player (componentWillUnmount ) I got this error :

Event handlers cannot be overwritten

Is there something else I should do when I when to delete the player ?

Contributor guide

Research direction
Investigate the lifecycle of the youtube player and React. Check if the player has a destroy method or if event handlers need to be removed before re creation. Look at the source code for event binding patterns.
Tech stack
javascriptreact
Domain
frontendweb dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70