gajus/wholly

Add selection option

Open

#9 opened on Aug 2, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (29 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (201 stars)
PR merge metrics
 (PR metrics pending)

Description

This will be good if the cells selection is set as an option. For example:

 defaultOptions = {
     highlightHorizontal: null,
     highlightVertical: null,
     selection: 'td, th'
 };

And in code:

table.on('mouseenter', options.selection, function () {
...
}

table.on('mouseleave', options.selection, mouseleave);

So user can decide wich cells are processed.

$('table').wholly({
    highlightHorizontal: 'horizontal-class-name',
    highlightVertical: 'vertical-class-name',
    selection: 'td:not(".skip")'
})

Contributor guide

Research direction
Implement a 'selection' option in the default options, then use it in the mouseenter and mouseleave event handlers to filter target cells. Update the code to pass the selector to the on() method.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptjQuery
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75