gajus/wholly

td with display:none should be treated as rowspan=0,colspan=0

Open

#8 opened on Jun 5, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (29 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (201 stars)
PR merge metrics
 (PR metrics pending)

Description

Consider a table where some of the are switched on and off by having "style='display:none'". For a of this type, it is removed entirely from the table, and the HTML treats it as never existing (effectively a zero rowspan/colspan).

However, wholly still counts these cells as if they were there with a normal colspan/rowspan of 1.

As a result, the vertical/horizontal highlighting goes completely crooked.

Contributor guide

Research direction
Inspect the cell counting logic in the plugin to exclude cells with display:none, treating them as colspan=0 and rowspan=0.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
jQuery
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75