gajus/scalpel

Incorrectly quotes in paranthesis

Open

#13 opened on Sep 23, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (7 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (97 stars)
PR merge metrics
 (PR metrics pending)

Description

The generator quotes content in parenthesis: Input string to AST:

body:not(.wp-admin)

Output string from AST:

body:not(".wp-admin")

Which will cause a parse error in the browser (Chrome).

Contributor guide

Research direction
Inspect the code that converts AST back to string, specifically how it handles pseudo class arguments like :not(). The quotes are likely added unconditionally; need to remove them for arguments that are CSS selectors.
Tech stack
javascript
Domain
backendweb dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptCSS selectors
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70