gajus/liqe

Parsing of Field Grouping not working

Open

#30 opened on Feb 17, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (27 forks)github user discovery
help wanted

Repository metrics

Stars
 (675 stars)
PR merge metrics
 (PR metrics pending)

Description

Problem

  • Parsing of Field Grouping throws error
  • Error is thrown as well in case of +/- prefix and missing field name
  • All examples below parse correctly with Java Lucene parser
  • Syntax is in line with:
  • Fixing this would:
    • Increase compatibility with Lucene
    • Provide alternative for providing list of values in format a:(b OR c OR d) or a:(b c d) (later in case of possibility to change default operator to OR)

Example of failing searches

  • +(a b)
  • -(a b)
  • c:(a b)
  • +c:(a b)
  • -c:(a b)

Versions 3.5.0 - on https://npm.runkit.com/liqe 3.6.0 - with Angular 14.0.4

Demonstration

https://runkit.com/embed/msogu7iiwefg

Contributor guide

Research direction
Inspect the parser's handling of field grouping and prefixes in the codebase. Focus on the lexer or parser rules for 'field:(...)' and '+/ prefix'. Add test cases for the failing examples and trace the error path.
Tech stack
typescript
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65