Node engine is too permissive

Open Beginner friendly
#43 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
node.js, typescript
Domain
backend

Research direction

Open package.json and inspect the engines.node declaration. Compare the declared minimum with the Node 14.15.5 failure and the linked Node changelog for crypto UUID support. Done means the package metadata no longer claims support for versions where randomUUID is unavailable.

Written by the indexing model from the issue text.

Description

Running on node 14.15.5 gives an error:

/Users/agoldis/currents-demo/node_modules/fast-json-stringify/index.js:83
  rootSchemaId = schema.$id || randomUUID()
                               ^
TypeError: randomUUID is not a function
    at build (/Users/agoldis/currents-demo/node_modules/fast-json-stringify/index.js:83:32)
    at Object.<anonymous> (/Users/agoldis/currents-demo/node_modules/roarr/dist/src/Roarr.js:15:57)

However, engines field of package.json claims

"engines": {
    "node": ">=14"
  },

14.17+ would be a better option

Dominant language
TypeScript
Stars
335
Forks
29
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from gajus/http-terminator

All issues in gajus/http-terminator

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.