gajus/flow-runtime

Type Destructors current status

Open

#234 opened on Jul 24, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (810 stars) (58 forks)batch import
enhancementhelp wanted

Description

This is a:

  • Bug Report
  • Feature Request
  • Question
  • Other

Which concerns:

  • flow-runtime
  • babel-plugin-flow-runtime
  • flow-runtime-validators
  • flow-runtime-mobx
  • flow-config-parser
  • The documentation website

Let's track list of implemented type destructors:

  • $Keys
  • $Values
  • $Exact
  • $Diff
  • $Rest
  • $PropertyType
  • $ElementType
  • $NonMaybeType
  • $ObjMap
  • $ObjMapi
  • $TupleMap
  • $Call
  • Class
  • $Shape
  • $Supertype
  • $Subtype
  • $ReadOnly
  • $CharSet
  • $Compose
  • $ComposeReverse

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with Flow type systemJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
The issue lists missing type destructors such as $Rest, $ElementType, $NonMaybeType, $Call, $ReadOnly, $CharSet, $Compose, $ComposeReverse. Review the existing implementations in the flow runtime source code, likely in src/type destructor.js. Choose a simple missing destructor like $ReadOnly and study the pattern used by implemented ones (e.g., $Keys). Then implement the missing destructor following the same pattern, ensuring it works with the existing test suite.