gajus/eslint-plugin-flowtype

Add rule to enforce error codes on flow suppressions

Open

#453 opened on Aug 19, 2020

View on GitHub
 (2 comments) (2 reactions) (0 assignees)JavaScript (167 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,078 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Flow version 0.121.0 allows for more specific error suppressions: https://medium.com/flow-type/making-flow-error-suppressions-more-specific-280aa4e3c95c

It would be wonderful if we could have a rule which requires these specific error suppressions:

  • // $FlowFixMe would fail since it has no valid error code specified
  • // $FlowFixMe[incompatible-type] would pass since it does have a valid error code

Contributor guide

Research direction
Implement a new ESLint rule that checks for specific error codes in Flow suppression comments.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLintFlow
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60