gajus/eslint-plugin-flowtype

require-return-type with { 'annotateUndefined': 'always' } should not trigger for class constructors

Open

#449 opened on Jun 29, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,078 stars) (167 forks)batch import
bughelp wanted

Description

require-return-type with { 'annotateUndefined': 'always' } should not trigger for class constructors, since class constructors should never return anything.

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ESLint plugin developmentFlow type system basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look at the `require return type` rule implementation, likely in `src/rules/requireReturnType.js`. The issue is that when `annotateUndefined` is set to 'always', the rule incorrectly flags class constructors. The fix involves adding an exception to skip constructors. Check the rule's logic for detecting constructor context (e.g., checking if the parent node is a class method with `kind` equal to 'constructor'). There are no existing comments or PRs on this issue, so it is unclaimed.