gajus/babel-plugin-react-css-modules

Classnames have trailing whitespace when spread is used

Open

#262 opened on Jun 30, 2019

View on GitHub
 (3 comments) (4 reactions) (0 assignees)JavaScript (2,044 stars) (176 forks)batch import
enhancementhelp wanted

Description

Example: JSX:

<div styleName="classA classB" {...someProps} />

Output:

<div className="classA classB " />

No trailing whitespace is added when spread is not used.

Seems like a small issue, but it breaks snapshots or className checks in tests when upgrading.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptReact knowledgeUnderstanding of Babel plugins
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the babel plugin react css modules source code, particularly the part that handles JSX spread attributes. Look at how styleName is converted to className and identify where trailing whitespace is added. The issue is likely in the string concatenation logic. Check the test files for existing tests and consider adding a test case for spread attributes.