gajus/babel-plugin-react-css-modules

Classnames have trailing whitespace when spread is used

Open

#262 opened on Jun 30, 2019

View on GitHub
 (3 comments) (4 reactions) (0 assignees)JavaScript (176 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (2,044 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Example: JSX:

<div styleName="classA classB" {...someProps} />

Output:

<div className="classA classB " />

No trailing whitespace is added when spread is not used.

Seems like a small issue, but it breaks snapshots or className checks in tests when upgrading.

Contributor guide

Research direction
Investigate the code that processes styleName attribute, specifically when spread attributes are used. The trailing whitespace likely comes from concatenation without trimming. Ensure that when merging styleName from spread, trailing spaces are removed.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70