gaearon/react-side-effect

React v16: Error during mount causes instance to never be removed from mountedInstances

Open

#40 opened on Oct 9, 2017

View on GitHub
 (33 comments) (1 reaction) (0 assignees)JavaScript (75 forks)github user discovery
help wanted

Repository metrics

Stars
 (1,214 stars)
PR merge metrics
 (PR metrics pending)

Description

I'm guessing componentWillUnmount isn't called. Would a fix be to listen to componentDidCatch, splice the array as in componentWillUnmount and then rethrow the error?

Contributor guide

Research direction
Investigate how componentDidCatch can be used to clean up mountedInstances when an error occurs during mount in React v16.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70