frzyc/genshin-optimizer

Add 22.7 ER to roll correction

Open

#2,222 opened on Jun 9, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (270 forks)auto 404
good first issue

Repository metrics

Stars
 (999 stars)
PR merge metrics
 (PR metrics pending)

Description

https://discord.com/channels/785153694478893126/1249365040470036540 The 22.7% of this artifact for a 5 low roll is not rounded correctly, need to add to roll correction. image

Contributor guide

Research direction
Find the roll correction logic in the codebase and add the missing 22.7% ER value.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80