frzyc/genshin-optimizer

Disallow certain GO ads to appear in banner ads

Open

#2,118 opened on May 13, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (270 forks)auto 404
good first issue

Repository metrics

Stars
 (999 stars)
PR merge metrics
 (PR metrics pending)

Description

image

Since the side banner ads have limited width now, if it doesnt fit in its smallest form factor, 160x600, then they should not be displayed.

Contributor guide

Research direction
Investigate the banner ad component to find where ad size constraints are defined and apply a filter to prevent ads that do not fit the minimum dimensions from being displayed.
Tech stack
typescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60