frzyc/genshin-optimizer

When scanning an upgraded artifact, do not unequip the artifact

Open

#1,470 opened on Jan 29, 2024

View on GitHub
 (0 comments) (1 reaction) (0 assignees)TypeScript (270 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (999 stars)
PR merge metrics
 (PR metrics pending)

Description

When a user scans an artifact that is then detected as an upgrade, users have shared they do not want the location information to be set to 'unequipped'. This is because the artifact card from the Character screen never shows location information, unlike the artifact card from the Inventory screen. This lack of location is currently interpreted by the scanner as 'unequip this artifact', when users would prefer it stay equipped.

The common workflow shared is that someone will go to a character to upgrade an equipped artifact. Then they will scan that card and upload it to GO to keep their DB in sync.

This does shift the problem to the reverse case, where users who upgrade an artifact that is equipped in GO, but not equipped in game, will now see this discrepancy when they upload a scan. Based on the common workflow described above, shifting the issue like this might be a 'lesser of two evils' solution

Contributor guide

Research direction
Investigate the current scanning logic for artifact upgrades and modify the behavior to not unequip the artifact when it is detected as an upgrade. Consider the trade off for the reverse case.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70