froala/design-blocks

A11y Accessibility valid markup

Open

#53 opened on Nov 2, 2017

View on GitHub
 (4 comments) (2 reactions) (0 assignees)HTML (13,642 stars) (1,223 forks)batch import
enhancementgood first issuehelp wanted

Description

Not a single form field has a label. These designs are not usable and the patterns presented should be discouraged.

I suggest adding a validation check like Nu Validator, aXe, lighthouse, etc. to show all the places this markup is invalid.

Contributor guide

Tech stack
htmlcss
Domain
frontendaccessibility
Issue type
accessibility
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
HTML basicsAccessibility standards
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests adding an automated validation check for missing form labels. Consider integrating a tool like aXe (axe core) or Lighthouse in CI or as a browser extension. Look at the existing HTML files in the repository to identify all forms and fields. The repo uses Bootstrap, so ensure labels are correctly associated. A PR could add a script that runs aXe on the built site and reports errors.
A11y Accessibility valid markup · froala/design-blocks#53 | Good First Issue