frintjs/frint

Maintenance: Upgrade to React v16

Open

#435 opened on Jul 16, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (746 stars) (37 forks)batch import
help wantedproposal

Description

Currently

Our API of frint-react is based on the context API of React v15.

React v16 still supports the old (v15) context API in deprecated mode, but also makes room for additional improvements.

It has also introduced APIs like getDerivedStateFromProps , making way for better async rendering (while also deprecating componentWillReceiveProps).

Proposal

We already have some additional proposals which make the API of FrintJS more simpler and stays close to the Component lifecycle where possible. Making it even easier to migrate to React v16:

  • #424: Access to app instance synchronously
  • #428: Region component with render prop support
  • #433: MountApp component
  • #436: Pass Region's props to Child Apps' root Components directly

While migrating to React v16, we can:

  • Drop observe HoC
  • Drop data prop in Region component
  • Drop RegionService

Because parent props as a stream would be difficult to access, since componentWillReceiveProps is already deprecated and will be gone in React v17.

It will have to be a breaking change.

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
React v15 API knowledgeUnderstanding of frint reactComponent lifecycleAsync rendering concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
The issue requires upgrading frint react to React v16, which involves dropping the `observe` HoC, `data` prop in Region, and RegionService. It also references sub issues #424, #428, #433, #436. Contributors should first understand the current React v15 context API usage and then replace deprecated lifecycle methods like componentWillReceiveProps with getDerivedStateFromProps. It would be helpful to review the linked PRs that were already completed (e.g., #428, #436) to understand the new patterns. Since this is a breaking change, careful testing is needed.