frintjs/frint

Proposal: App registration upon availability of other Apps

Open

#432 opened on Jul 12, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (37 forks)batch import
help wantedproposal

Repository metrics

Stars
 (746 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently

If we want to wait for certain Apps to be available first, before registering a new App, we do it like this:

window.app.getAppOnceAvailable$('FooApp').subscribe(
  fooApp => window.app.registerApp(BazApp)
);

Proposal

We can make things a bit more easier:

window.app.registerAppOnceAvailable(['FooApp', 'BarApp'], BazApp);

(not convinced with the method name registerOnceAvailable yet)

Relates to #425

Contributor guide

Research direction
Implement a new method `registerAppOnceAvailable` that accepts an array of app names and an app to register. Use `getAppOnceAvailable$` for each app and combine them with `forkJoin` or `zip`. When all are available, register the new app.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptRxJS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70