frintjs/frint

frint-react: Move subscription to componentDidMount in `observe` HoC

Open

#417 opened on Apr 11, 2018

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (746 stars) (37 forks)batch import
help wanted

Description

At the moment, it's happening in componentWillMount, which is not recommended.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic React lifecycle knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue asks to move the subscription from componentWillMount to componentDidMount in the `observe` higher order component. Since componentWillMount is deprecated in newer React versions, this is a straightforward migration. Look for the relevant HoC file in the frint react package, find where componentWillMount is used, and move the subscription logic to componentDidMount. Ensure to update any related tests if they exist.