frintjs/frint

Match package versions after hoisting

Open

#402 opened on Jan 12, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (746 stars) (37 forks)batch import
help wanted

Description

Since we introduced $ lerna bootstrap --hoist, we now notice that versions of some third-party dependencies within the packages do not match the versions as defined in root package.json.

We need to fix them.

lerna WARN EHOIST_ROOT_VERSION The repository root depends on react@^16.0.0, which differs from the more common react@^15.5.4.
lerna WARN EHOIST_PKG_VERSION "frint-react-server" package depends on react@^15.5.4, which differs from the hoisted react@^16.0.0.
lerna WARN EHOIST_ROOT_VERSION The repository root depends on react-dom@^16.0.0, which differs from the more common react-dom@^15.5.4.
lerna WARN EHOIST_PKG_VERSION "frint-react-server" package depends on react-dom@^15.5.4, which differs from the hoisted react-dom@^16.0.0.
lerna WARN EHOIST_PKG_VERSION "frint-cli" package depends on lodash@^4.17.4, which differs from the hoisted lodash@^4.13.1.
lerna WARN EHOIST_PKG_VERSION "frint-router" package depends on lodash@^4.17.4, which differs from the hoisted lodash@^4.13.1.

Contributor guide

Tech stack
javascriptnodejs
Domain
build systemdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of lerna monorepoBasic knowledge of npm versioningFamiliarity with frint project structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue lists warnings about version mismatches after hoisting. The fix involves updating the package.json files in the affected packages: for frint react server, change react@^15.5.4 to ^16.0.0 and react dom@^15.5.4 to ^16.0.0; for frint cli and frint router, update lodash@^4.13.1 to ^4.17.4. Run `lerna bootstrap hoist` to verify the warnings are resolved. Ensure no other packages have similar mismatches.