frintjs/frint

frint-router-react: improve test coverage

Open

#269 opened on Aug 18, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (37 forks)batch import
help wanted

Repository metrics

Stars
 (746 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Current coverage report:

$ (cd ./packages/frint-router-react && npm run cover:report)

----------------|----------|----------|----------|----------|----------------|
File            |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------------|----------|----------|----------|----------|----------------|
All files       |    94.95 |    86.76 |    81.48 |    97.89 |                |
 Link.js        |      100 |    85.71 |      100 |      100 |       18,42,93 |
 Link.spec.js   |     97.6 |       50 |    91.67 |    97.58 |     18,268,282 |
 Route.js       |      100 |    96.55 |      100 |      100 |             20 |
 Route.spec.js  |    96.53 |      100 |    86.84 |      100 |                |
 Switch.js      |      100 |       80 |      100 |      100 |          15,37 |
 Switch.spec.js |    86.82 |    66.67 |    65.79 |    94.07 |... 65,67,75,77 |
----------------|----------|----------|----------|----------|----------------|

Contributor guide

Research direction
Look at the uncovered lines in Link.js, Link.spec.js, Route.js, Switch.js, and Switch.spec.js, and write tests to cover those lines.
Tech stack
javascriptreact
Domain
frontend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80