frintjs/frint

frint-react: Empty Component when Region is empty

Open

#216 opened on Jun 2, 2017

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (746 stars) (37 forks)batch import
featuregood first issuehelp wantedminor

Description

Current situation

Right now, when a Region has no Apps to render, it just remains empty.

It would be useful if we can pass some default Component to render in those cases.

Proposed API

import EmptyRegionContent from '../components/EmptyRegionContent';

<Region name="sidebar" empty={EmptyRegionContent} />

If the sidebar region is empty, it would render EmptyRegionContent component by default.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Reactfrint basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look into the Region component in the frint react package. Understand how it currently renders apps. Implement an 'empty' prop that accepts a React component and renders it when no apps are provided. Ensure to add unit tests for the new functionality. Check if there are any existing TypeScript definitions that need updating.