fregante/webext-storage-cache

`staleWhileRevalidate` may cause unhandledrejection errors

Closed

#49 opened on Oct 14, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (4 forks)github user discovery
help wanted

Repository metrics

Stars
 (82 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This is due to the async setTimeout(getSet) call. If the getter throws, then this error cannot be caught.

I'm not sure of how to handle this. Maybe:

  • item.onAsyncRejection(cb)
  • swallowAsyncRejections: true (default)
  • just use a global unhandledrejection handler, which loses the context/origin
    • maybe the errors can still be caught/rewrapped to add context

Contributor guide

Research direction
Investigate how to handle unhandled promise rejections from async setTimeout calls in the webext storage cache library. Review the current implementation and explore options like adding an onAsyncRejection callback or a swallowAsyncRejections config option.
Tech stack
javascript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70