fregante/content-scripts-register-polyfill

`includeGlobs` is not supported

Open

#35 opened on Oct 8, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (6 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (25 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi there! I am using your polyfill to register my content script via:

var content_script_registration_dict = { "matches":["*://*.twitch.tv/*"], "includeGlobs":['*player.twitch.tv*'], "js":[{file:"my_javascript.js"}], "css":[{file:"my_css.css"}] }

chrome.contentScripts.register(content_script_registration_dict);

However I am noticing that my includeGlobs segment is being ignored. Instead, it ignores the includeGlobs match pattern, and injects my_javascript.js into all pages under matches regardless of whether it matches includeGlobs or not.

When I instead place my JavaScript code inside the manifest.json file, everything works as expected, thus it appears to be an issue with this package.

I think that this is an important fix for this package since includeGlobs is currently not behaving as expected.

Thanks!

Contributor guide

Research direction
Investigate the polyfill's content script registration logic to see where includeGlobs is ignored. Look at how matches is processed and add handling for includeGlobs to filter matching URLs.
Tech stack
javascript
Domain
apifrontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70