fregante/GhostText

How to disconnect the field on the new GhostText?

Open

#178 opened on Jan 27, 2021

View on GitHubContributor guide
 (7 comments) (0 reactions) (0 assignees)JavaScript (133 forks)github user discovery
discussionhelp wanted

Repository metrics

Stars
 (3,611 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Originally posted by @subnut in https://github.com/GhostText/GhostText/issues/172#issuecomment-735098823:

If a field is currently connected, then clicking the GhostText extension icon and selecting the connected field should disconnect it.

Yeah the current disconnection logic isn't super clear. In the previous version you would just click the button again and it would disconnect, but now it just looks for more fields.

So the solution I came up with is to right click the button 😬 or to just close the editor tab (which would make more sense, since you're done with it so you want to go back to the browser)

Does anyone have any suggestions for an intuitive way to disconnect the editor from the browser?

Contributor guide

Research direction
Investigate how the current connection logic works (likely in background script). Look for a way to detect if a field is already connected and toggle off the connection when the extension icon is clicked on a connected field. You may need to add a state variable or use the existing connection tracker.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70