freezy/VisualPinball.Engine

Use LivecatchBounceMultiplier to reduce angular momentum instead of nulling it.

Open

#439 opened on Aug 29, 2022

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C# (72 forks)github user discovery
enhancementhelp wantedphysics

Repository metrics

Stars
 (498 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently, if a livecatch happens, angular momentum (only for x and y) is nulled, while livecatchbounceMultiplier is only used on velocity.

It could be tested, if the livecatches feel better, when the liveCatchBounceMultiplier (which is for example 0.2 for a slightly inaccurate livecatch) is not only applied to velocity, but also to the angular momentum.

	ball.Velocity -= collEvent.HitNormal * normalSpeed * liveCatchBounceMultiplier;
	ball.AngularMomentum.x = 0;
	ball.AngularMomentum.y = 0;

-->

	ball.Velocity -= collEvent.HitNormal * normalSpeed * liveCatchBounceMultiplier;
	ball.AngularMomentum.x *= liveCatchBounceMultiplier;
	ball.AngularMomentum.y *= liveCatchBounceMultiplier;

possibly only angular momentum in the direction of the collision-normal could be reduced. (like for velocity, or the same amount of the overall velocity reduction, otherwise calculation would be quite hard.)

Contributor guide

Research direction
Examine how liveCatchBounceMultiplier is applied to velocity, then apply the same multiplication to angular momentum components in the ball physics code. Consider optionally reducing only angular momentum in the collision normal direction.
Tech stack
csharp
Domain
game dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#basic physics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75