frappe/charts

Can we update format_tooltip_x and format_tooltip_y dynamically?

Open

#128 opened on Mar 2, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (769 forks)batch import
enhancementhacktoberfest

Repository metrics

Stars
 (14,858 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected Behaviour

Hey guys,

What do you think about changing format_tooltip_x and format_tooltip_y when you set new data like:

MyChart.update_values(datasets, labels);

It will be cool if we can use something like update_settings:

const unit = myUnit || 'foo';

MyChart.update_settings({
  colors: ['red', 'blue'],
  format_tooltip_x: d => `${d) ${unit}`,
  format_tooltip_y: d => `${d) ${unit}`,
  ...,
});

Here is a shot of what I can try to achieve: Image

When I click on requests I want to see XXX Requests then when I click on the Bandwidth I want to see XXX MB/GB/TB or something.

Actual Behaviour

We can update only the datasets and labels labels or maybe I'm missing something?

Contributor guide

Research direction
Investigate the current update mechanism in frappe charts and determine how to allow dynamic updates of tooltip format functions. Look at the update values method and see if there is a way to pass additional settings, or implement a new update settings method.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65