frappe/charts

Chart [min, max] does not optimise for values

Open

#100 opened on Dec 15, 2017

View on GitHub
 (3 comments) (3 reactions) (0 assignees)JavaScript (769 forks)batch import
enhancementhacktoberfest

Repository metrics

Stars
 (14,858 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected Behaviour

Chart min and max values should optimise for data values. This was also initially reported in https://github.com/frappe/charts/issues/57 and fixed after that.

Actual Behaviour

There is a bunch of space above and below the line (see image)

Steps to Reproduce:

Data values are from 13.45 to 14.52 Code is here: http://jsbin.com/wodujuk/1/edit?js,output

screen shot 2017-12-15 at 12 18 15 pm

Frappé Charts version: https://unpkg.com/frappe-charts@0.0.8/dist/frappe-charts.min.iife.js

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.