zulip/zulip

Improve open graph preview formatting meta issue

Open

#4 645 ouverte le 28 avr. 2017

Voir sur GitHub
 (3 commentaires) (0 réactions) (0 assignés)Python (7 339 forks)batch import
area: markdown (embeds/previews)help wanted

Métriques du dépôt

Stars
 (19 672 stars)
Métriques de merge PR
 (Merge moyen 36j 6h) (110 PRs mergées en 30 j)

Description

Zulip has this cool open graph website previews feature, but it needs some work before it makes sense to enable it by default:

  • We want a realm setting to disable them on a list of domains (which on chat.zulip.org would probably include github.com).
  • We probably don't want to display them at all when there's no image in the open graph data (it doesn't look good)
  • Already opened an issue for this (#4608) , but it doesn't handle relative URLs in the open graph data correctly.
  • The fetching code throws an exception when trying to preview sites with SSL errors (Which seems to include URLs on its own site). We should probably exclude the own site, and turn these into at most logged warnings.;
  • We probably want some sort of UI for hiding/disabling a preview in a given message.
  • We probably want to suppress repeat-appearances of URL previews of the same image in a thread within X time of a previous preview; that probably includes "in the same message". This may be a fairly involved feature that we split into its own project.

I think once most of these are fixed, we can probably turn the feature on by default; we probably don't need to get to 100%.

Guide contributeur