zulip/zulip

Optimize topic cache calculation for rendering `near`/`with` links in automated notices after moving topics.

Open

#33 276 ouverte le 31 janv. 2025

Voir sur GitHub
 (24 commentaires) (0 réactions) (0 assignés)Python (19 672 stars) (7 339 forks)batch import
area: message-editing (topics)area: performancehelp wanted

Description

This requires #30644 to be merged. See https://github.com/zulip/zulip/pull/30644#discussion_r1785332141 for details, but we might be able to use message IDs we just generated to prepopulate the topic cache to avoid extra queries when moving messages.

It might not be worth it; the queries are cheap and it would be potentially messy plumbing. I won't be certain until I see what the plumbing needs to look like.

But given that message-moving is a high importance code path that already has a lot of queries, it could be worth it.

Guide contributeur

Stack technique
pythondjango
Domaine
backendperformance
Type d'issue
performance
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
active
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
needs investigation
Prérequis
Understanding of message moving code pathFamiliarity with topic cache mechanism
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
30
Direction de recherche
Explore the implementation in #30644 and the discussion at the linked PR comment. Determine whether using message IDs from the generated messages can pre populate the topic cache to avoid additional queries during message moving. Evaluate the complexity of the required plumbing and trade offs. Files such as the message moving code and topic cache implementation in the Zulip server should be examined.