zulip/zulip

Topic Edit Typeahead interferes with IME selection

Open

#23 595 ouverte le 17 nov. 2022

Voir sur GitHub
 (10 commentaires) (0 réactions) (0 assignés)Python (19 672 stars) (7 339 forks)batch import
area: compose (typeahead)area: internationalizationbughelp wanted

Description

Basic Info

Zulip Server Version 6.0-dev-2443-g527b656fc9 Forked from upstream at 6.0-dev-2430-ge797715f1d Appears on both web and mac Desktop app V5.9.3

Expected Behavior

When editing topics using IME (for example Chinese) and there already exists a topic with matching character, text should only be inputted after composition event in IME is complete

Actual Behavior

GIVEN

  • editing/composing topics using IME (for example Chinese)
  • A topic already exists with first IME selection char

WHEN

  • Selecting character during inputEvent that doesn't match typeahead

THEN

  • the typeahead seems to trigger and inputs the character even before IME is done composing character

https://user-images.githubusercontent.com/15863509/202339373-e49085c9-402b-4897-8e0c-74743786517a.mov

Notes

This seems to be related to typeahead interfering with IME selection and triggering before the char selection is done

Guide contributeur

Stack technique
javascripttypescriptreact
Domaine
frontendaccessibility
Type d'issue
bug
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
3
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
1-3 hours
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
stale
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
JavaScriptReactIME composition events
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
45
Direction de recherche
The bug occurs when using an IME (e.g., Chinese) while editing topics. The typeahead triggers before IME composition is complete. To fix, examine the typeahead component's event handling, likely in the web app's frontend code (possibly in static/js/ or similar). Look for how keydown, compositionstart, compositionend events are processed. The fix should ensure typeahead only considers final composition text, not intermediate characters. Check existing comments for any suggested approach or related PRs.