Métriques du dépôt
- Stars
- (1 348 stars)
- Métriques de merge PR
- (Métriques PR en attente)
Description
This issue is to follow up on #4219 with some small UI improvements to the "$person will not be notified unless you subscribe them" warning which we added in #4101 (addressing #3373). Going through my comment at https://github.com/zulip/zulip-mobile/pull/4101#issuecomment-669764675 in order:
- button shape/size in visual appearance -- done in #4219
- button touch target to 48px (extending beyond visual button) -- still TODO
- no border -- done in #4219
- background color -- still TODO
- text/background color contrast, for legibility -- done in #4101 before merge
- cut animation -- done in #4219
- use a nice slide-in animation instead -- still TODO
See that comment for details on each of these. For the touch target, @chrisbobbe adds (at https://github.com/zulip/zulip-mobile/pull/4219#issuecomment-670784841 ) :
For this, we'll likely want to use the
hitSlopprop of the component that gets theonPressprop. We may have to adjust the dimensions of its parent, too:The touch area never extends past the parent view bounds and the Z-index of sibling views always takes precedence if a touch hits two overlapping views.