zephyrproject-rtos/zephyr

Bluetooth: Controller: Use defines for access_addr and crc_init array sizes

Open

#40 378 ouverte le 16 nov. 2021

Voir sur GitHub
 (2 commentaires) (0 réactions) (1 assigné)C (15 249 stars) (9 144 forks)batch import
EnhancementGood first issuearea: Bluetootharea: Bluetooth Controller

Description

Is your enhancement proposal related to a problem? Please describe. access_addr always seems to be of size 4; that should be #defined. crc_init always seem to be of size 3; that should be #defined.

https://github.com/zephyrproject-rtos/zephyr/pull/31009/files#r736229677 https://github.com/zephyrproject-rtos/zephyr/pull/31009/files#r736229386

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or graphics (drag-and-drop an image) about the feature request here.

Guide contributeur

Stack technique
c
Domaine
backend
Type d'issue
refactor
DifficultéDifficulté estimée pour un nouveau contributeur, de 1 pour un très petit changement à 5 pour un travail expert.
2
Temps estiméFourchette de temps approximative pour investiguer, implémenter, tester et préparer une pull request.
under 1 hour
Statut d'activitéDisponibilité apparente de l'issue : fraîche, active, ancienne, bloquée ou en attente d'un mainteneur.
blocked
ClartéClarté avec laquelle l'issue explique le changement attendu, les critères d'acceptation et la prochaine étape.
clear
Prérequis
C programmingZephyr RTOS basicsBluetooth controller conceptsGit and PR workflow
Accessibilité débutantScore de 1 à 100 estimant l'accessibilité de cette issue pour un premier contributeur.
70
Direction de recherche
Examine the linked PR #31009 at the specific comment lines to identify where hardcoded array sizes appear for access addr and crc init. Then, define macros for those sizes (e.g., BT CTLR ACCESS ADDR SIZE and BT CTLR CRC INIT SIZE) and replace the hardcoded values throughout the Bluetooth controller code. The changes should be isolated to the controller module. Verify that no other occurrences exist in the codebase.