yugabyte/yugabyte-db
Voir sur GitHub[DocDB] Allow Docdb flush/compact rate limiter to specify the granularity of enforcement.
Open
#13 404 ouverte le 22 juil. 2022
area/docdbgood first issuekind/enhancementpriority/medium
Métriques du dépôt
- Stars
- (8 229 stars)
- Métriques de merge PR
- (Merge moyen 17j 21h) (92 PRs mergées en 30 j)
Description
Jira Link: DB-3034
Description
Rocksdb Rate limiter supports specifying the granularity at which the rate is enforced. This defaults to 100ms
extern RateLimiter* NewGenericRateLimiter(
int64_t rate_bytes_per_sec,
int64_t refill_period_us = 100 * 1000,
int32_t fairness = 10);
However, Docdb doesn't seem to be specifying the granularity and only uses the 100ms default. This can be an issue if the underlying cloud provider enforces their rate limits at a smaller interval.
std::shared_ptr<rocksdb::RateLimiter> CreateRocksDBRateLimiter() {
if (PREDICT_TRUE((FLAGS_rocksdb_compact_flush_rate_limit_bytes_per_sec > 0))) {
return std::shared_ptr<rocksdb::RateLimiter>(
rocksdb::NewGenericRateLimiter(FLAGS_rocksdb_compact_flush_rate_limit_bytes_per_sec));
}
return nullptr;
}
A large chunk of write from a flush/compaction may adversely impact our latencies on WAL writes.