yugabyte/yugabyte-db

[DocDB] Add flag for configuring rocksdb bytes_per_sync option

Open

#10 822 ouverte le 9 déc. 2021

Voir sur GitHub
 (2 commentaires) (0 réactions) (1 assigné)C (1 003 forks)batch import
area/docdbgood first issuekind/enhancementpriority/medium

Métriques du dépôt

Stars
 (8 229 stars)
Métriques de merge PR
 (Merge moyen 17j 21h) (92 PRs mergées en 30 j)

Description

Jira Link: DB-590

Description

  // Allows OS to incrementally sync files to disk while they are being
  // written, in the background. Issue one request for every bytes_per_sync
  // written. 0 turns it off.
  // Default: 0
  uint64_t bytes_per_sync = 0;
DBOptions SanitizeOptions(const std::string& dbname, const DBOptions& src) {
...
  if (result.rate_limiter.get() != nullptr) {
    if (result.bytes_per_sync == 0) {
      result.bytes_per_sync = 1024 * 1024;
    }
  }
...

Currently, we don't set bytes_per_sync explicitly, but we use a rate limiter, so it leads to sync every 1MB (independently for each file) at rocksdb level.

Guide contributeur